Skip to content
This repository has been archived by the owner on Jan 13, 2023. It is now read-only.

Update the core commands to match the latest IRI 1.8.1 release #235

Closed
pdecol opened this issue Sep 17, 2019 · 2 comments
Closed

Update the core commands to match the latest IRI 1.8.1 release #235

pdecol opened this issue Sep 17, 2019 · 2 comments

Comments

@pdecol
Copy link
Contributor

pdecol commented Sep 17, 2019

The core commands implement the API endpoints which are provided by IRI and are contained in the StrictIota class. I compared the current implementation with the latest IRI 1.8.1 release (https://github.com/iotaledger/iri/blob/v1.8.1-RELEASE/src/main/java/com/iota/iri/service/API.java). The following changes are needed to get StrictIota up to date.

Missing commands:

Missing parameters:

  • getBalances: tips is missing as an optional parameter. references is new in the response and could be added to the response filter.
  • getTransactionsToApprove: references is missing as an optional parameter.

Changed fields in the response:

  • getBalances: milestone (type: Address) get removed and milestoneIndex (type: int) got added to the response. Shall we remove milestone? Or keep both to ensure backwards compatibility?

Fields that I would add to the response filter because without these values in the response the API call is useless:

  • wereAddressesSpentFrom: states
  • checkConsistency: state

Furthermore for all commands :

Let me know what you think. I planning to implement this myself and I will open a pull request soon.

@todofixthis
Copy link
Contributor

Wow, this is amazing! 😻 Thanks @pdecol !

@GalRogozinski
Copy link
Contributor

The IRI team needs this issue fixed for our regression tests.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants