Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review iota-graphql test coverage #4135

Merged
merged 12 commits into from
Nov 28, 2024

Conversation

samuel-rufi
Copy link
Member

Description of change

Reviews the test coverage for iota-graphql-rpc and iota-graphql-e2e-tests.

Links to any relevant issues

Fixes #1562

Type of change

  • Documentation

How the change has been tested

cargo nextest run --features pg_integration --no-fail-fast --test-threads 1

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@samuel-rufi samuel-rufi self-assigned this Nov 19, 2024
@samuel-rufi samuel-rufi requested a review from a team as a code owner November 19, 2024 14:40
Copy link
Contributor

@tomxey tomxey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🌄

@alexsporn alexsporn added the infrastructure Issues related to the Infrastructure Team label Nov 26, 2024
@samuel-rufi samuel-rufi merged commit 64bca64 into develop Nov 28, 2024
38 of 39 checks passed
@samuel-rufi samuel-rufi deleted the l1sc/infra/review-iota-graphql-coverage branch November 28, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Issues related to the Infrastructure Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task (Infrastructure)]: Review implementation and coverage of graphql-rpc tests
4 participants