address comments

iotexproject · Jan 22, 2024 · 3b16390 · 3b16390
1 parent fe68fac
commit 3b16390
Showing 1 changed file with 1 addition and 4 deletions.
diff --git a/action/protocol/staking/protocol.go b/action/protocol/staking/protocol.go
@@ -494,10 +494,6 @@ func (p *Protocol) isActiveCandidate(ctx context.Context, csr CandidateStateRead
 	if address.Equal(vb.Owner, cand.Owner) {
 		return true, nil
 	}
-	// bucket is not endorsed to the candidate
-	if !address.Equal(vb.Candidate, cand.Owner) {
-		return false, nil
-	}
 	esr := NewEndorsementStateReader(csr.SR())
 	endorse, err := esr.Get(cand.SelfStakeBucketIdx)
 	switch {
@@ -513,6 +509,7 @@ func (p *Protocol) isActiveCandidate(ctx context.Context, csr CandidateStateRead
 		return false, err
 	default:
 		// endorsement does not exist
+		return false, errors.New("endorsement does not exist")
 	}
 	return true, nil
 }