[action] add action deserializer #3190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dustinxie
commented
Mar 14, 2022
| type Deserializer struct { | ||
| } | ||
|
|
||
| func (ad *Deserializer) ActionToSealedEnvelope(pbAct *iotextypes.Action) (SealedEnvelope, error) { |
There was a problem hiding this comment.
similar to block deserializer, the purpose of this PR is to contain the pending changes
PR 3188 will change in here
Codecov Report
@@ Coverage Diff @@
## master #3190 +/- ##
=======================================
Coverage 74.96% 74.97%
=======================================
Files 226 227 +1
Lines 21203 21207 +4
=======================================
+ Hits 15895 15899 +4
Misses 4469 4469
Partials 839 839
Continue to review full report at Codecov.
|
Liuhaai
approved these changes
Mar 14, 2022
CoderZhi
approved these changes
Mar 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.