Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[db] Add unit test for branchNode #3457

Closed
wants to merge 6 commits into from

Conversation

huof6829
Copy link
Contributor

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #3201

Type of change

Please delete options that are not relevant.

  • [] Bug fix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [] Code refactor or improvement
  • [] Breaking change (fix or feature that would cause a new or changed behavior of existing functionality)
  • [] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • [] make test
  • [] fullsync
  • [] Other test (please specify)

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • [] My code follows the style guidelines of this project
  • [] I have performed a self-review of my code
  • [] I have commented my code, particularly in hard-to-understand areas
  • [] I have made corresponding changes to the documentation
  • [] My changes generate no new warnings
  • [] I have added tests that prove my fix is effective or that my feature works
  • [] New and existing unit tests pass locally with my changes
  • [] Any dependent changes have been merged and published in downstream modules

@huof6829 huof6829 requested a review from a team as a code owner June 17, 2022 13:08
@codecov
Copy link

codecov bot commented Jun 17, 2022

Codecov Report

Merging #3457 (16d92cf) into master (1f10a0f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3457   +/-   ##
=======================================
  Coverage   75.28%   75.28%           
=======================================
  Files         241      241           
  Lines       22258    22258           
=======================================
  Hits        16758    16758           
  Misses       4597     4597           
  Partials      903      903           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f10a0f...16d92cf. Read the comment docs.

@Liuhaai
Copy link
Member

Liuhaai commented Jun 17, 2022

The trie is redesigned in the prs ( #3194, #3193 ). The test is to be added after the change is merged.

@huof6829 huof6829 closed this Sep 30, 2022
@huof6829 huof6829 deleted the fix_3201 branch December 29, 2022 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add unit test for branchNode
2 participants