[ioctl] Build action command line into new ioctl

[LuckyPigeon]

Description

Refactor action command in new ioctl, with the following note.

• Use client interface to construct the Cobra command.
• Output package is deprecated, replace it with errors package.
• Replace fmt.Println with cmd.Println
• Refactor unit test to cover the modification.

Type of change

Please delete options that are not relevant.

• Code refactor or improvement

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

• make test
• TestNewActionHashCmd

Test Configuration:

• Firmware version: Ubuntu 21.04
• Hardware:
• Toolchain:
• SDK:

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

[codecov]

Codecov Report

Merging #3472 (e3c34b6) into master (a20e489) will decrease coverage by 1.42%.
The diff coverage is 38.00%.

@@            Coverage Diff             @@
##           master    #3472      +/-   ##
==========================================
- Coverage   75.43%   74.01%   -1.43%     
==========================================
  Files         247      253       +6     
  Lines       22845    23339     +494     
==========================================
+ Hits        17233    17274      +41     
- Misses       4685     5135     +450     
- Partials      927      930       +3     

Impacted Files	Coverage Δ
blockchain/blockchain.go	0.89% <0.00%> (ø)
blockchain/pubsubmanager.go	0.00% <0.00%> (ø)
config/config.go	94.06% <ø> (+9.31%)	⬆️
ioctl/newcmd/alias/alias.go	0.00% <0.00%> (ø)
ioctl/newcmd/bc/bc.go	37.50% <0.00%> (+0.46%)	⬆️
ioctl/util/util.go	40.00% <0.00%> (ø)
ioctl/newcmd/action/action.go	20.62% <20.62%> (ø)
actpool/config.go	60.00% <60.00%> (ø)
blockchain/config.go	65.78% <65.78%> (ø)
action/protocol/poll/protocol.go	68.13% <66.66%> (-0.35%)	⬇️
... and 35 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1866c0...e3c34b6. Read the comment docs.

[LuckyPigeon]

@huof6829
Need help! Unit test for SendAction and Execute (Execute is depends on SendAction`), I couldn't find the correct private key for the signer. Here's my current code.

iotex-core/ioctl/newcmd/action/action_test.go

Lines 103 to 127 in 47a7cfd

	func TestSendAction(t *testing.T) {
	require := require.New(t)
	ctrl := gomock.NewController(t)
	client := mock_ioctlclient.NewMockClient(ctrl)
	apiServiceClient := mock_iotexapi.NewMockAPIServiceClient(ctrl)
	response := &iotexapi.SendActionResponse{}
	tx := &action.Execution{}
	elp := (&action.EnvelopeBuilder{}).
	SetNonce(0).
	SetGasPrice(unit.ConvertIotxToRau(1100000)).
	SetGasLimit(100).
	SetAction(tx).Build()
	client.EXPECT().SelectTranslation(gomock.Any()).Return("mockTranslationString", config.English).Times(2)
	client.EXPECT().SetEndpointWithFlag(gomock.Any()).Do(func(_ func(*string, string, string, string)) {})
	client.EXPECT().SetInsecureWithFlag(gomock.Any()).Do(func(_ func(*bool, string, bool, string)) {})
	client.EXPECT().APIServiceClient().Return(apiServiceClient, nil)
	apiServiceClient.EXPECT().SendAction(gomock.Any(), gomock.Any()).Return(response, nil)
	t.Run("sends signed action to blockchain", func(t *testing.T) {
	cmd := NewActionCmd(client)
	err := SendAction(client, cmd, elp, "test")
	require.Error(err) // This should be NoError, but couldn't design a correct signer with public key.
	})
	}

[huof6829]

@huof6829 Need help! Unit test for SendAction and Execute (Execute is depends on SendAction`), I couldn't find the correct private key for the signer. Here's my current code.

iotex-core/ioctl/newcmd/action/action_test.go

Lines 103 to 127 in 47a7cfd

	func TestSendAction(t *testing.T) {
	require := require.New(t)
	ctrl := gomock.NewController(t)
	client := mock_ioctlclient.NewMockClient(ctrl)
	apiServiceClient := mock_iotexapi.NewMockAPIServiceClient(ctrl)
	response := &iotexapi.SendActionResponse{}
	tx := &action.Execution{}
	elp := (&action.EnvelopeBuilder{}).
	SetNonce(0).
	SetGasPrice(unit.ConvertIotxToRau(1100000)).
	SetGasLimit(100).
	SetAction(tx).Build()
	client.EXPECT().SelectTranslation(gomock.Any()).Return("mockTranslationString", config.English).Times(2)
	client.EXPECT().SetEndpointWithFlag(gomock.Any()).Do(func(_ func(*string, string, string, string)) {})
	client.EXPECT().SetInsecureWithFlag(gomock.Any()).Do(func(_ func(*bool, string, bool, string)) {})
	client.EXPECT().APIServiceClient().Return(apiServiceClient, nil)
	apiServiceClient.EXPECT().SendAction(gomock.Any(), gomock.Any()).Return(response, nil)
	t.Run("sends signed action to blockchain", func(t *testing.T) {
	cmd := NewActionCmd(client)
	err := SendAction(client, cmd, elp, "test")
	require.Error(err) // This should be NoError, but couldn't design a correct signer with public key.
	})
	}

I fixed. Pls check it. argument singer is generated from keystore which is created first. so the private key can be exported correctly.

[LuckyPigeon]

@huof6829 Thanks for the help!

[huof6829]

You can refer to action.go in #3444. it's the same file

[LuckyPigeon]

@huof6829
When I write test for action.go, the command won't catch my flag args, even I've already gave args by the following command.

_, err := util.ExecuteCmd(cmd, "--signer", "test")

Did I miss understand something?
My code is in the following commit.

[huof6829]

--signer is not registered in NewActionCmd() . you can catch flag after registered it in NewActionCmd before ExecuteCmd.

[huof6829]

Is TestSendAction removed ?

[huof6829]

If codes is too large. we can split to small prs: one or two TestXxx per pr. What do you think of it ? @LuckyPigeon

[LuckyPigeon]

TestSendAction has removed temporily, since it isn't completed yet.
I think sperate PRs will be better. TestSendRaw and TestSigner are alike, they can be in same PR. TestSendAction, TestExecute and TestRead and similar, they can be in a PR.

[LuckyPigeon]

I'll open another PR for the rest 3 test case.

[huof6829]

@LuckyPigeon Ok.

[huof6829]

@LuckyPigeon This pr just finish TestSendRaw and TestSigner. Other Testxxx is another pr. Thanks.