Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[api] impl. TestGrpcServer_GetServerMeta #3559

Merged
merged 1 commit into from Jul 19, 2022
Merged

[api] impl. TestGrpcServer_GetServerMeta #3559

merged 1 commit into from Jul 19, 2022

Conversation

ghost
Copy link

@ghost ghost commented Jul 17, 2022

Description

[api] Impletment TestGrpcServer_GetServerMeta by gomock CoreService interface.

Fixes #3529

Type of change

  • Code refactor or improvement

How Has This Been Tested?

  • make test
  • Other test (go test github.com/iotexproject/iotex-core/api)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@ghost ghost self-requested a review as a code owner July 17, 2022 16:26
@CLAassistant
Copy link

CLAassistant commented Jul 17, 2022

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Jul 17, 2022

Codecov Report

Merging #3559 (ef20fa7) into master (a20e489) will decrease coverage by 1.36%.
The diff coverage is 38.00%.

@@            Coverage Diff             @@
##           master    #3559      +/-   ##
==========================================
- Coverage   75.43%   74.06%   -1.37%     
==========================================
  Files         247      253       +6     
  Lines       22845    23339     +494     
==========================================
+ Hits        17233    17286      +53     
- Misses       4685     5123     +438     
- Partials      927      930       +3     
Impacted Files Coverage Δ
blockchain/blockchain.go 0.89% <0.00%> (ø)
blockchain/pubsubmanager.go 0.00% <0.00%> (ø)
config/config.go 94.06% <ø> (+9.31%) ⬆️
ioctl/newcmd/alias/alias.go 0.00% <0.00%> (ø)
ioctl/newcmd/bc/bc.go 37.50% <0.00%> (+0.46%) ⬆️
ioctl/util/util.go 40.00% <0.00%> (ø)
ioctl/newcmd/action/action.go 20.62% <20.62%> (ø)
actpool/config.go 60.00% <60.00%> (ø)
blockchain/config.go 65.78% <65.78%> (ø)
action/protocol/poll/protocol.go 68.13% <66.66%> (-0.35%) ⬇️
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7783ced...ef20fa7. Read the comment docs.

@CoderZhi CoderZhi merged commit 8d1e836 into iotexproject:master Jul 19, 2022
pocockn added a commit to pocockn/iotex-core that referenced this pull request Jul 19, 2022
…task/config-get

* 'task/config-get' of github.com:pocockn/iotex-core:
  modify test
  move chanid metrics to chainservice (iotexproject#3544)
  [ioctl] fix log entries created from user input (iotexproject#3546)
  add log in rolldposctx (iotexproject#3553)
  fix uncontrolled data used in path expression (iotexproject#3547)
  [api] impl. TestGrpcServer_GetServerMeta (iotexproject#3559)
pocockn added a commit to pocockn/iotex-core that referenced this pull request Jul 20, 2022
…task/set-config

* 'task/set-config' of github.com:pocockn/iotex-core:
  [test] Disable workingset cache in the benchmark test (iotexproject#3558)
  [pkg] fix  deferring unsafe method "Close" on type "*os.File" (iotexproject#3548)
  [action] Refactor handleTransfer() (iotexproject#3557)
  Add MinVersion in tls.Config (iotexproject#3562)
  [ioctl] Modify file permission as 0600 (iotexproject#3563)
  [httputil] add ReadHeaderTimeout (iotexproject#3550)
  [staking] unexport namespace (iotexproject#3551)
  move chanid metrics to chainservice (iotexproject#3544)
  [ioctl] fix log entries created from user input (iotexproject#3546)
  add log in rolldposctx (iotexproject#3553)
  fix uncontrolled data used in path expression (iotexproject#3547)
  [api] impl. TestGrpcServer_GetServerMeta (iotexproject#3559)
  [ioctl] Build action command line into new ioctl (iotexproject#3472)
  fix potential file inclusion via variable (iotexproject#3549)
pocockn added a commit to pocockn/iotex-core that referenced this pull request Jun 3, 2023
* upstream/master: (45 commits)
  Task: Get config cmd (iotexproject#3552)
  [ioctl] fix  Errors unhandled (iotexproject#3567)
  fix dir permission and file inclusion (iotexproject#3566)
  [test] Disable workingset cache in the benchmark test (iotexproject#3558)
  [pkg] fix  deferring unsafe method "Close" on type "*os.File" (iotexproject#3548)
  [action] Refactor handleTransfer() (iotexproject#3557)
  Add MinVersion in tls.Config (iotexproject#3562)
  [ioctl] Modify file permission as 0600 (iotexproject#3563)
  [httputil] add ReadHeaderTimeout (iotexproject#3550)
  [staking] unexport namespace (iotexproject#3551)
  move chanid metrics to chainservice (iotexproject#3544)
  [ioctl] fix log entries created from user input (iotexproject#3546)
  add log in rolldposctx (iotexproject#3553)
  fix uncontrolled data used in path expression (iotexproject#3547)
  [api] impl. TestGrpcServer_GetServerMeta (iotexproject#3559)
  [ioctl] Build action command line into new ioctl (iotexproject#3472)
  fix potential file inclusion via variable (iotexproject#3549)
  [ioctl] Incorrect conversion between integer types (iotexproject#3522)
  [action] fix incorrect conversion between integer types (iotexproject#3545)
  [test] fix TestLoadBlockchainfromDB (iotexproject#3521)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[api] impletment TestGrpcServer_GetServerMeta by gomock CoreService interface
3 participants