Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iip15] fix caused EVM error when the contract was not registered #3929

Merged
merged 2 commits into from
Nov 16, 2023

Conversation

millken
Copy link
Contributor

@millken millken commented Aug 28, 2023

Description

if the contract is not registered, return nil to prevent the evm from throwing error

Fixes #(issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [] Code refactor or improvement
  • [] Breaking change (fix or feature that would cause a new or changed behavior of existing functionality)
  • [] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • make test
  • [] fullsync
  • [] Other test (please specify)

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • [] My code follows the style guidelines of this project
  • [] I have performed a self-review of my code
  • [] I have commented my code, particularly in hard-to-understand areas
  • [] I have made corresponding changes to the documentation
  • [] My changes generate no new warnings
  • [] I have added tests that prove my fix is effective or that my feature works
  • [] New and existing unit tests pass locally with my changes
  • [] Any dependent changes have been merged and published in downstream modules

@sonarcloud
Copy link

sonarcloud bot commented Aug 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Liuhaai
Copy link
Member

Liuhaai commented Sep 6, 2023

what scenario is the contract not registered

@millken
Copy link
Contributor Author

millken commented Sep 7, 2023

what scenario is the contract not registered

contracts that have not applied for IIP15 are considered unregistered

EVM will check whether the contract has registered IIP15, the current SGD will return an error if it is not registered. But the error will cause EVM error too. so we cannot return error here

Copy link

sonarcloud bot commented Nov 16, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
4.7% 4.7% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Attention: 503 lines in your changes are missing coverage. Please review.

Comparison is base (e1f0636) 75.38% compared to head (47aa3a0) 76.13%.
Report is 102 commits behind head on master.

❗ Current head 47aa3a0 differs from pull request most recent head 309639a. Consider uploading reports for the commit 309639a to get more accurate results

Files Patch % Lines
blockindex/contractstaking/event_handler.go 67.23% 45 Missing and 13 partials ⚠️
action/protocol/staking/staking_statereader.go 69.76% 35 Missing and 17 partials ⚠️
action/protocol/execution/evm/evm.go 42.16% 47 Missing and 1 partial ⚠️
action/protocol/staking/protocol.go 33.33% 28 Missing ⚠️
...tion/protocol/staking/contractstake_bucket_type.go 0.00% 24 Missing ⚠️
blockindex/contractstaking/util.go 39.47% 22 Missing and 1 partial ⚠️
action/protocol/rewarding/fund.go 23.07% 19 Missing and 1 partial ⚠️
api/coreservice.go 69.69% 14 Missing and 6 partials ⚠️
api/websocket.go 0.00% 20 Missing ⚠️
action/protocol/execution/evm/evmstatedbadapter.go 0.00% 19 Missing ⚠️
... and 29 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3929      +/-   ##
==========================================
+ Coverage   75.38%   76.13%   +0.75%     
==========================================
  Files         303      330      +27     
  Lines       25923    28139    +2216     
==========================================
+ Hits        19541    21423    +1882     
- Misses       5360     5615     +255     
- Partials     1022     1101      +79     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@millken millken merged commit 8eb196d into iotexproject:master Nov 16, 2023
3 of 4 checks passed
dustinxie added a commit that referenced this pull request Aug 8, 2024
dustinxie added a commit that referenced this pull request Aug 10, 2024
dustinxie added a commit that referenced this pull request Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants