-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[iip15] fix caused EVM error when the contract was not registered #3929
Conversation
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
what scenario is the contract not registered |
contracts that have not applied for IIP15 are considered unregistered EVM will check whether the contract has registered IIP15, the current SGD will return an error if it is not registered. But the error will cause EVM error too. so we cannot return error here |
SonarCloud Quality Gate failed. 0 Bugs No Coverage information Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3929 +/- ##
==========================================
+ Coverage 75.38% 76.13% +0.75%
==========================================
Files 303 330 +27
Lines 25923 28139 +2216
==========================================
+ Hits 19541 21423 +1882
- Misses 5360 5615 +255
- Partials 1022 1101 +79 ☔ View full report in Codecov by Sentry. |
Description
if the contract is not registered, return nil to prevent the evm from throwing error
Fixes #(issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: