Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix SimulateExecution, add sgd contract check #3983

Merged
merged 7 commits into from
Nov 23, 2023

Merge branch 'master' into iip15-fix-simulator

9d0a29c
Select commit
Loading
Failed to load commit list.
Merged

fix SimulateExecution, add sgd contract check #3983

Merge branch 'master' into iip15-fix-simulator
9d0a29c
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Nov 23, 2023 in 0s

76.13% (target 85.00%)

View this Pull Request on Codecov

76.13% (target 85.00%)

Details

Codecov Report

Attention: 510 lines in your changes are missing coverage. Please review.

Comparison is base (e1f0636) 75.38% compared to head (9d0a29c) 76.13%.
Report is 110 commits behind head on master.

Files Patch % Lines
blockindex/contractstaking/event_handler.go 67.23% 45 Missing and 13 partials ⚠️
action/protocol/staking/staking_statereader.go 69.76% 35 Missing and 17 partials ⚠️
action/protocol/execution/evm/evm.go 44.30% 43 Missing and 1 partial ⚠️
action/protocol/staking/protocol.go 33.33% 28 Missing ⚠️
...tion/protocol/staking/contractstake_bucket_type.go 0.00% 24 Missing ⚠️
api/coreservice.go 67.60% 17 Missing and 6 partials ⚠️
blockindex/contractstaking/util.go 39.47% 22 Missing and 1 partial ⚠️
action/protocol/rewarding/fund.go 23.07% 19 Missing and 1 partial ⚠️
api/websocket.go 0.00% 20 Missing ⚠️
action/protocol/execution/evm/evmstatedbadapter.go 0.00% 19 Missing ⚠️
... and 30 more
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3983      +/-   ##
==========================================
+ Coverage   75.38%   76.13%   +0.75%     
==========================================
  Files         303      330      +27     
  Lines       25923    28146    +2223     
==========================================
+ Hits        19541    21429    +1888     
- Misses       5360     5614     +254     
- Partials     1022     1103      +81

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov