Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[iip-15] Sharing gas-fee for DApps (#3844)" (#4361) #4361

Merged
merged 2 commits into from
Aug 13, 2024
Merged

Conversation

dustinxie
Copy link
Member

Description

2nd PR for reverting IIP-15. This reverts the SGD implementation inside EVM (and entire feature in the codebase)

Fixes #(issue)

Type of change

Please delete options that are not relevant.

  • [] Bug fix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • Code refactor or improvement
  • [] Breaking change (fix or feature that would cause a new or changed behavior of existing functionality)
  • [] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • [] make test
  • fullsync
  • [] Other test (please specify)

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • [] My code follows the style guidelines of this project
  • [] I have performed a self-review of my code
  • [] I have commented my code, particularly in hard-to-understand areas
  • [] I have made corresponding changes to the documentation
  • [] My changes generate no new warnings
  • [] I have added tests that prove my fix is effective or that my feature works
  • [] New and existing unit tests pass locally with my changes
  • [] Any dependent changes have been merged and published in downstream modules

Copy link

sonarcloud bot commented Aug 13, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
13.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link

codecov bot commented Aug 13, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes missing coverage. Please review.

Project coverage is 75.86%. Comparing base (cc526cd) to head (36f0d99).
Report is 91 commits behind head on master.

Files Patch % Lines
action/protocol/execution/evm/evm.go 0.00% 2 Missing ⚠️
action/protocol/poll/consortium.go 0.00% 1 Missing ⚠️
action/protocol/poll/staking_committee.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4361      +/-   ##
==========================================
- Coverage   77.02%   75.86%   -1.17%     
==========================================
  Files         342      361      +19     
  Lines       29406    30116     +710     
==========================================
+ Hits        22651    22846     +195     
- Misses       5650     6134     +484     
- Partials     1105     1136      +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dustinxie dustinxie merged commit 36f0d99 into master Aug 13, 2024
2 of 5 checks passed
@dustinxie dustinxie deleted the sgd2 branch August 13, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants