Enable the ternary operator to evaluate builtin calls #1405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suyuee
force-pushed
the
ternary_evaluate_builtin
branch
from
1e0bb96
to
8f16e58
Compare
|
For anyone else following along, this same behavior is allowed in C/C++: https://godbolt.org/z/H2q2Yt |
fbs
reviewed
Jul 2, 2020
suyuee
force-pushed
the
ternary_evaluate_builtin
branch
from
8f16e58
to
8ca2f0e
Compare
|
@ember526 can you also include the non checklist bits in the PR description in your commit message? 80 column wide formatting, though. |
Currently, the ternary operator can only works to evaluate strings and
integers. This tries to include builtin calls:
```
# bpftrace -e 'BEGIN { pid > 10000 ? printf("%s %d\n", comm, pid) : exit(); }'
```
Although if-else statement can serve the purpose, using ternary can be
more concise especially when users run bpftrace in comand line. In
bpftrace, builtin calls have `none` types so it makes sense for the
ternary operator to support them. Resolves bpftrace#1333.
suyuee
force-pushed
the
ternary_evaluate_builtin
branch
from
8ca2f0e
to
90549e9
Compare
|
@danobi Sure. Hope this will do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the ternary operator can only works to evaluate strings and integers. This PR tries to include builtin calls:
Although if-else statement can server the purpose, using ternary can be more concise especially when users run bpftrace in comand line. In bpftrace, builtin calls have
nonetypes so it makes sense for the ternary operator to support them. Resolves #1333.Checklist
docs/reference_guide.mdCHANGELOG.md