Fix type resolution for field access via variables #1450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would it be possible to test this behaviour? Our ci doesn't run these kfunc tests yet but they would be good to have to avoid regressions |
viktormalik
force-pushed
the
field-analyser-fix
branch
from
d1d5db3
to
4aeebca
Compare
Good point, I added a new test case for this. Also verified that the test doesn't pass without this fix. |
|
One of the CI tests failed but it is not related to this PR. I think that a restart should fix that. |
|
Rerunning tests |
|
Failed on Docker container build this time. |
|
yeey tests finally pass. Can you fix the clang formatting issues? :) |
fbs
approved these changes
Aug 10, 2020
viktormalik
force-pushed
the
field-analyser-fix
branch
from
4aeebca
to
b93170c
Compare
|
@viktormalik can you update the changelog too? |
If a variable of a (pointer to) struct type is defined, its type must be saved. Later, when the variable is used, the stored type helps to correctly resolve types of following field accesses. Fixes iovisor#1362. Add a unit test that requires this fix.
viktormalik
force-pushed
the
field-analyser-fix
branch
from
b93170c
to
386b74c
Compare
Sure, done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1362
The problem is that the field analyser was not able to correctly resolve struct field types if a variable (of struct type) was used because it doesn't remember the variable type.
It only worked for cases when the variable was used right after its definition since the type was remembered in the
type_field of the field analyser (see the linked issue for examples).This PR fixes the problem by storing the variable type and using it when the variable is used.
Checklist
docs/reference_guide.mdCHANGELOG.md