Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix array indexing regression #1457

Merged
merged 1 commit into from
Aug 6, 2020
Merged

Fix array indexing regression #1457

merged 1 commit into from
Aug 6, 2020

Conversation

danobi
Copy link
Member

@danobi danobi commented Aug 6, 2020 •
edited
Loading

We regressed on array indexing because the CreateArray() helper forgot
to set pointee_size. This caused all array indexes to silently index to
index 0.

Checklist
  • Language changes are updated in docs/reference_guide.md
  • User-visible and non-trivial changes updated in CHANGELOG.md

@danobi danobi requested a review from fbs August 6, 2020 16:05
@danobi
Fix array indexing regression
21e9a72 
We regressed on array indexing because the CreateArray() helper forgot
to set pointee_size. This caused all array indexes to silently index to
index 0.
@danobi
Copy link
Member Author

danobi commented Aug 6, 2020

#1394 will kill pointee_size. It'd be nice to merge this in now so the pointer PR will be tested against the regression test.

@fbs fbs merged commit 4cc6f80 into bpftrace:master Aug 6, 2020
@viktormalik viktormalik mentioned this pull request Mar 26, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbs fbs Awaiting requested review from fbs fbs is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danobi @fbs