Support multi-matched globbed target files for uprobe and usdt #1499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viktormalik
force-pushed
the
uprobe-usdt-glob-binaries
branch
from
0a845ef
to
90d44dd
Compare
|
Look ok! Adding std::filesystem should be fine, shame the detection has to happen like this but I don't see a better way either. |
GCC version <9 and Clang (all versions) require a special linker flag to support std::filesystem.
The default GCC versions in Bionic and Xenial do not support std::filesystem. This change is needed so that we can start using std::filesystem and the CI handles it.
find_wildcard_matches now returns the "path:fun" form for uprobes. Adjust both regression and runtime tests to handle this new form. Add a new test that tests glob expansion for binaries.
find_wildcard_matches now returns "target:namespace:probename" form for usdt probes. If a process PID is specified, all binaries and libraries executed by the process should be searched for usdt probes. If a target path is specified along with a PID, only the binaries/libraries matching the path are searched. Adjust regression and runtime tests to the new behavior and modify a test for usdt wildcards to test the path wildcard, too. One of the runtime tests must be skipped in embedded Alpine builds.
viktormalik
force-pushed
the
uprobe-usdt-glob-binaries
branch
from
90d44dd
to
0d3fd30
Compare
danobi
approved these changes
Sep 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change is pretty straightforward, it's mostly achieved by changing the form of strings returned by
find_wildcard_matchesfor these probe types (the new form istarget:functionfor uprobe andtarget:namespace:probenamefor usdt) and handling the new form where needed.A noticeable behavior is for usdt probes when a process PID is specified. By default, all binaries and libraries executed by the process are searched for usdt probes. If a target path is specified along with a PID, only the binaries/libraries matching the path are searched. I wonder if this information should be put into the Reference Guide.
Resolves #1113.
Note: this change introduces usage of
std::filesystem. This requires some changes, in particular adding the-lstdc++fslinker flag for some compiler versions and using GCC version 8 in Docker images (since GCC 7 does not supportstd::filesystem). These changes will probably be needed for #1263, too.Checklist
docs/reference_guide.mdCHANGELOG.md