Warn if attaching a kprobe to a non-traceable function #1835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viktormalik
force-pushed
the
warn-notrace-functions
branch
from
7a55ac7 to
abdb0fb
Compare
Currently, bpf_attach_kprobe will fail and we are relying on libbpf to provide an error message. This one may be confusing, though, so it is better if we print our own warning to the user. A similar check is already done for kfuncs, so this commit moves the appropriate code from BTF to the BPFtrace class to unify it.
viktormalik
force-pushed
the
warn-notrace-functions
branch
from
abdb0fb to
a8b2d1c
Compare
danobi
reviewed
May 13, 2021
| @@ -24,6 +26,10 @@ class BTF | |||
|
|
|||
| public: | |||
| BTF(); | |||
There was a problem hiding this comment.
Any other callers of this? I'd rather BTF() only have one constructor so nobody forgets to pass BPFtrace*
There was a problem hiding this comment.
Unfortunately yes, it's called from BPFfeature which doesn't have access to BPFtrace (bpffeature.cpp:199)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when trying to attach a kprobe a non-traceable function,
bpf_attach_kprobewill fail and we're relying on libbpf to print an error message. This error messgage may be confusing (see example in #1818) though, so it's better if we print our own warning to the user.Checklist
docs/reference_guide.mdCHANGELOG.md