Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tracepoint: Return 1 from tracepoint probes #1857

Merged
merged 1 commit into from
Jun 3, 2021
Merged

Conversation

danobi
Copy link
Member

@danobi danobi commented May 25, 2021

Returning 0 from a tracepoint prog causes the perf subsystem to ignore
the tracepoint event. We should return 1 to be a better citizen.

And yes, everyone in the kernel thinks it's weird too. But it's too late
to change.

Checklist
  • Language changes are updated in docs/reference_guide.md
  • User-visible and non-trivial changes updated in CHANGELOG.md
  • The new behaviour is covered by tests

Copy link
Member

@fbs fbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lame :( but looks ok

Returning 0 from a tracepoint prog causes the perf subsystem to ignore
the tracepoint event. We should return 1 to be a better citizen.

And yes, everyone in the kernel thinks it's weird too. But it's too late
to change.
@danobi danobi merged commit cc0aecc into bpftrace:master Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants