Expand int syntax #1900
Merged
Expand int syntax #1900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TODO:
|
danobi
reviewed
Jul 8, 2021
src/ast/attachpoint_parser.cpp
Outdated
| @@ -5,14 +5,42 @@ | |||
| #include <functional> | |||
| #include <string> | |||
| #include <unordered_map> | |||
| #include <variant> | |||
There was a problem hiding this comment.
Accidental include? Don't see any variant usage in this commit
src/ast/int_parser.cpp
Outdated
| template <typename T> | ||
| T _parse_int(const std::string &num, size_t *idx, int base) | ||
| { | ||
| throw std::runtime_error("parse_int not implemented for type"); |
There was a problem hiding this comment.
I think we can make this a compile time error instead. Example: https://godbolt.org/z/sEs3xhac4
fbs
force-pushed
the
1898_ints
branch
3 times, most recently
from
7357141
to
60b582c
Compare
danobi
approved these changes
Jul 15, 2021
By centralising this logic we can re-use it for uniform int handling throughout our AST. This parser supports `_`s as int separators, e.g. 1_000_000
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow us use underscores as int digit separator to improve readability, e.g. 1_000_000 and unifies the int parsing logic allowing us to use the same syntax in attach points. E.g. hardware:cache-misses:1e6 or 1_000 are now valid instead.
The exponent parsing thing feels a bit clunky, c++ supports it out of the box but for doubles only, might be easier to just use that instead. But its hidden behind a simple interface so we can always change it if needed.
Fixes #1897
Fixes #1898