Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

codegen: Disable LLVM loop unrolling #1967

Merged
merged 3 commits into from
Aug 10, 2021
Merged

codegen: Disable LLVM loop unrolling #1967

merged 3 commits into from
Aug 10, 2021

Conversation

danobi
Copy link
Member

@danobi danobi commented Aug 9, 2021 •
edited
Loading

B/c of verifier instruction limits, it's better to handle loop unrolling
from bpftrace and not leave it up to LLVM.

Checklist
  • Language changes are updated in man/adoc/bpftrace.adoc and if needed in docs/reference_guide.md
  • User-visible and non-trivial changes updated in CHANGELOG.md
  • The new behaviour is covered by tests

@danobi danobi force-pushed the disable_loop_unroll branch from a81a4df to d162ec4 Compare August 9, 2021 19:08
danobi added 3 commits August 9, 2021 15:12
@danobi
codegen: Disable LLVM loop unrolling
ea962c9 
B/c of verifier instruction limits, it's better to handle loop unrolling
from bpftrace and not leave it up to LLVM.
@danobi
Add no unroll codegen test
eb96904
@danobi
Update CHANGELOG
2bd7b29
@danobi danobi force-pushed the disable_loop_unroll branch from d162ec4 to 2bd7b29 Compare August 9, 2021 22:14
@danobi danobi merged commit c13a769 into bpftrace:master Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viktormalik viktormalik viktormalik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danobi @viktormalik