codegen: Fix interaction with verifier when accessing ctx field twice #2008
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The verifier doesn't like it if we modify the ctx pointer twice before
dereferencing it. In other words, ctx+8 is OK, but ctx+4+4 is NOT.
The reasoning in kernel land is due to interactions w/ socket buffer
(skb) access rewrites. Without this limitation, the kernel may let the
prog write past the end of the skb.
We trip over this issue when accessing the same tracepoint field twice.
LLVM decides to save ctx+8 in a temporary register and reuse the value
when indexing into the struct in the unrolled memcpy loop.
Fix this issue by using bpf_probe_read_*() so that we only modify the
ctx pointer once.
Checklist
man/adoc/bpftrace.adoc
and if needed indocs/reference_guide.md
CHANGELOG.md