Fix uprobe:address expansion #2138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like CI is broken. #2139 should fix that. |
fbs
approved these changes
Feb 3, 2022
|
thanks! |
If no function is specified on uprobe (typically when an absolute address is given), do not run expansion in the probe matcher as that would match all functions in the target binary which we don't want. This fixes a bug when trying to attach to an absolute address while using the "probe" builtin (which requires probe expansion). See iovisor/bpftrace#2135 for details.
E.g.: uprobe:./prog*:0x1234 This is not supported anyway and would end with "No probes to attach". This way, we throw an error, which is more informative.
viktormalik
force-pushed
the
probe-expansion-fix
branch
from
b1f675c to
0f25644
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uprobe:target:addressshould never be expanded - neither whentargetcontains a wildcard, nor when, e.g.,probebuiltin is used within the probe. This makes sure expansion doesn't happen. See individual commits for more details.Fixes #2135.
Checklist
man/adoc/bpftrace.adocand if needed indocs/reference_guide.mdCHANGELOG.md