Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

biosnoop.bt: handle Linux 5.17 block layer update #2207

Merged
merged 1 commit into from
May 17, 2022

Conversation

viktormalik
Copy link
Contributor

@viktormalik viktormalik commented May 9, 2022

The kernel upstream commit f3fa33acc has removed the rq_disk field from struct request. Instead, ->q->disk should be used, so this is reflected in biosnoop.bt.

The old version of the tool (suitable for kernel <= 5.16) is backed up in tools/old and used in the CI.

Fixes #2220.

Checklist
  • Language changes are updated in man/adoc/bpftrace.adoc and if needed in docs/reference_guide.md
  • User-visible and non-trivial changes updated in CHANGELOG.md
  • The new behaviour is covered by tests

The kernel upstream commit:

    torvalds/linux@f3fa33a

has removed the `rq_disk` field from `struct request`. Instead,
`->q->disk` should be used, so this is reflected in biosnoop.bt.

The old version of the tool (suitable for kernel <= 5.16) is backed up
in tools/old and used in the CI.
@viktormalik viktormalik added this to the 0.15.0 milestone May 11, 2022
@fbs fbs merged commit 1c295d8 into bpftrace:master May 17, 2022
@viktormalik viktormalik deleted the biosnoop-new branch May 25, 2022 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Biosnoop broken on kernel 5.16+
2 participants