Fix codegen for buf #2217
Merged
Fix codegen for buf #2217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The second parameter of 'buf' specifies the number of bytes to read. Codegen generates an 'icmp' instruction to compare the supplied number with the maximum length. This instruction may introduce a problem when the supplied number is not a 64-bit integer, hence this commit adds a 'zext' typecast.
viktormalik
force-pushed
the
buf-codegen-fix
branch
from
fb6c7a9
to
6da0f43
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The second parameter of
bufspecifies the number of bytes to read. Codegen generates anicmpinstruction to compare the supplied number with the maximum length. This instruction may introduce a problem when the supplied number is not a 64-bit integer, hence this commit adds a 'zext' typecast.Fixes #2215. Also related to #2129 and #2182.
Checklist
man/adoc/bpftrace.adocand if needed indocs/reference_guide.mdCHANGELOG.md