add pton builtin #2289
Merged
add pton builtin #2289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danobi
reviewed
Jul 8, 2022
fbs
reviewed
Jul 11, 2022
fbs
reviewed
Jul 11, 2022
viktormalik
reviewed
Jul 13, 2022
xh4n3
force-pushed
the
features/add-pton-builtin
branch
2 times, most recently
from
0024f1e
to
61d95e1
Compare
|
@danobi @fbs @viktormalik Thanks for the suggestions! |
danobi
reviewed
Jul 16, 2022
viktormalik
reviewed
Jul 18, 2022
xh4n3
force-pushed
the
features/add-pton-builtin
branch
from
61d95e1
to
0a1cb3d
Compare
xh4n3
force-pushed
the
features/add-pton-builtin
branch
from
0a1cb3d
to
3e1bc64
Compare
Signed-off-by: xh4n3 <xyn1016@gmail.com>
Signed-off-by: xh4n3 <xyn1016@gmail.com>
xh4n3
force-pushed
the
features/add-pton-builtin
branch
from
3e1bc64
to
314928d
Compare
|
@viktormalik @danobi The inet_pton check has been added to semantic analyser, it should find empty string or illegal address in the first place now. |
viktormalik
approved these changes
Jul 18, 2022
|
Hi @danobi , would you like to take another look? The issues you mentioned should be fixed now. |
danobi
approved these changes
Jul 28, 2022
viktormalik
approved these changes
Jul 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request addressed the proposal in #2248, added a new built-in function
pton.The
ptonconverts text-formatted IP addresses to byte arrays, which is exactly reversed-version ofntop. It should come in handy when we need to select packets with certain IP addresses.Plan
The current implementation only support comparison byte by byte, direct byte array comparison will be implemented in future pull requests.
Checklist
man/adoc/bpftrace.adocand if needed indocs/reference_guide.mdCHANGELOG.md