Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: bump bpftrace version to v0.19.1 #205

Merged
merged 6 commits into from
Jul 16, 2024
Merged

feat: bump bpftrace version to v0.19.1 #205

merged 6 commits into from
Jul 16, 2024

Conversation

cakemanny
Copy link
Contributor

@cakemanny cakemanny commented May 4, 2024 •
edited
Loading

This resolves #200

It bumps the bptrace version to v0.19.1 .

I chose 0.19.1 as it's the most recent quay.io/iovisor/bpftrace tag. (It seems they are working on switching to using a Nix based build for later versions).
I wasn't able to successfully able to bump bcc.

The other changes are related to

  • getting the Github Actions to run in the forked repo - i.e. $GIT_ORG is expanded in integration tests
  • getting the integration tests to pass with more recent versions of Minikube and Kind.
    • I ended up bumping the version of go in order to be able to debug locally, so I hope it's ok that that's included also.

By all means let me know if it needs additional touches or splitting out into separate PRs.

PS: also fixes #174

@cakemanny cakemanny marked this pull request as draft May 4, 2024 20:54
@cakemanny
Copy link
Contributor Author

cakemanny commented May 4, 2024 •
edited
Loading

It seems the github actions are actually failing still, I'll have to come back to this. I've put in draft mode for now.
I also tried to follow the instructions for signing the commits but for some reason they're showing as unverified so I'll have to revisit that too.

Now fixed. I'd simply gone a bit too far with the go builder base image; switching from bookworm back to bullseye sorted that. I also added something to output pod log contents when a test case fails.

@cakemanny cakemanny marked this pull request as ready for review May 4, 2024 23:36
@cakemanny
Copy link
Contributor Author

@fntlnz, would you be the one to look at this?

@fntlnz fntlnz self-requested a review May 20, 2024 12:53
@fntlnz
Copy link
Member

fntlnz commented May 20, 2024

Thanks @cakemanny - This was long due. I'll take a look

@fntlnz
Copy link
Member

fntlnz commented Jun 25, 2024 •
edited
Loading

I'm still looking into this @cakemanny - I did not forget! Thanks again !

@cakemanny
Copy link
Contributor Author

Hey @fntlnz, I guess you've still not had time? Or is there something I can do to help, such as break parts out or explain better anything that looks a bit mysterious?

@fntlnz
Copy link
Member

fntlnz commented Jul 8, 2024

@cakemanny yes it's just my schedule the PR looks good to review, please hang on and thanks again for the great work.

fntlnz
fntlnz approved these changes Jul 16, 2024
View reviewed changes
Copy link
Member

@fntlnz fntlnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! There are certain things that require further work like the versions you mentioned but this is good to be merged and we can add those later.

Thanks for the patience @cakemanny and for the contribution 🎉

@fntlnz fntlnz merged commit 4da82e6 into iovisor:master Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fntlnz fntlnz fntlnz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update bpftrace to 0.18.0 FindPidByPodContainer unreliable
2 participants
@cakemanny @fntlnz