Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Kinetic release #19

Closed
tdinesh opened this issue Jan 11, 2017 · 10 comments
Closed

Question: Kinetic release #19

tdinesh opened this issue Jan 11, 2017 · 10 comments

Comments

@tdinesh
Copy link
Contributor

tdinesh commented Jan 11, 2017

Is there a plan to release this for Kinetic/Gazebo 7.4?
The hardware_interface::ControllerInfo API is changed. Also Gazebo 7.4 gazebo::physics::Joint API is different.

@fmessmer
Copy link
Member

We are currently working on preparing kinetic branches for our repos...
However, so far we haven't started to work on this plugin...@ipa-bnm did you have a look at this already?

Contributions are very welcome...I just created a kinetic_dev branch 😉

@fmessmer
Copy link
Member

fmessmer commented Jan 12, 2017

We even might to think about contributing this back to the official https://github.com/ros-controls/gazebo_ros_control package, but there they don't seem to be prepared for kinetic, too....don't know how simulation with gazebo currently works under kinetic at all...I'm not yet there...

@tdinesh
Copy link
Contributor Author

tdinesh commented Jan 12, 2017

I would be happy to contribute. Had already started to make the API changes. Will create a pull request once I get it working.

@tdinesh
Copy link
Contributor Author

tdinesh commented Jan 12, 2017

I have the plugin working with kinetic and gazebo. But travis is failing. Can you check the scripts?
travis.install.sh and travis.script.sh.

@fmessmer
Copy link
Member

Thanks for the PR #21
However, it might take a while until we are actually able to test and release...

I guess travis fails because it does not support xenial...in all the other repos we are currentliy switching to https://github.com/ros-industrial/industrial_ci which is based on docker.
@ipa-bnm FYI

@benmaidel
Copy link
Member

+1 for #21
Yes travis is failing because xenial is not officially supported. We switched to ros-industrial/industrial_ci but are using our own fork for now.
@tdinesh An example for an working .travis.yaml for kinetic can be found here: https://github.com/ipa320/cob_environments/tree/kinetic_dev. Would be great if you could include a working travis config into this PR.

@tdinesh
Copy link
Contributor Author

tdinesh commented Jan 13, 2017

Thanks @ipa-bnm. I have fixed the PR.

@fmessmer
Copy link
Member

fmessmer commented Jan 19, 2017

@tdinesh
Out of couriosity, what (simulated) robot are you using this plugin with?
What's your usecase?
Would you be interested in an E-Stop behavior (see #16)?
Would you support a transfer of the plugin to official gazebo_ros_pkgs - I already mentioned this once in a comment?
Just asking because we haven't played back any feature from the original repo...don't know whether there is anything new in gazebo_ros_control plugin anyway

@tdinesh
Copy link
Contributor Author

tdinesh commented Jan 20, 2017

@ipa-fxm
We are using the Kuka LBR iiwa 7 platform.
The LBR has SmartServos which can switch torque/position control. But this was not available in Gazebo for https://github.com/SalvoVirga/iiwa_stack.
E-stop behaviour would be good to have.
I would support a transfer of the plugin. Even, I haven't seen anything new in gazebo_ros_control.
Hope this answers everything.

@fmessmer fmessmer mentioned this issue Jan 31, 2017
@fmessmer
Copy link
Member

fmessmer commented Aug 1, 2017

cob_gazebo_plugins is release to kinetic (0.7.1-0)
http://repositories.ros.org/status_page/ros_kinetic_default.html?q=cob_gazebo_plugins

@fmessmer fmessmer closed this as completed Aug 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants