Skip to content
This repository has been archived by the owner on Apr 16, 2020. It is now read-only.

Setup needs support benchmarks with multiple nodes. #10

Open
daviddias opened this issue Apr 12, 2017 · 0 comments
Open

Setup needs support benchmarks with multiple nodes. #10

daviddias opened this issue Apr 12, 2017 · 0 comments

Comments

@daviddias
Copy link
Collaborator

daviddias commented Apr 12, 2017

We will need to have benchmarks with more than one node, so that we can benchmark things like exchange and pubsub. These multiple node tests will not make sense for profiling, so a good strategy to isolate them might be to have ./suite/benchmark/ and ./suite/profile/ for specific benchmark and profiling tests respectively and running any test found at ./suite/ in both lands (to avoid duplication of code).

A way that this could be done is by changing the benchmark suite signature to look like:

module.exports = function (callback) {
  const nNodes = 1
  function benchmark (nodes, callback) {
    const ipfs = nodes[0]
    ipfs.files.add([{
      path: 'a.txt',
      content: new Buffer('a')
    }], callback)
  }
  callback(null, nNodes, benchmark)
}

This way the node spawning would still remain independent from running the benchmark.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant