From 210dabb3a857bd6e832f37c64b90ad0fcdba6519 Mon Sep 17 00:00:00 2001 From: Pedro Teixeira Date: Fri, 12 Jan 2018 15:33:31 +0000 Subject: [PATCH] chore: update dependency: pump version 2.0 (#668) --- package.json | 2 +- src/log/tail.js | 3 ++- src/utils/converter.js | 5 +++-- src/utils/send-request.js | 3 ++- 4 files changed, 8 insertions(+), 5 deletions(-) diff --git a/package.json b/package.json index 2ade22be6..ab520573a 100644 --- a/package.json +++ b/package.json @@ -44,7 +44,7 @@ "promisify-es6": "^1.0.3", "pull-defer": "^0.2.2", "pull-pushable": "^2.1.2", - "pump": "^1.0.3", + "pump": "^2.0.0", "qs": "^6.5.1", "readable-stream": "^2.3.3", "stream-http": "^2.7.2", diff --git a/src/log/tail.js b/src/log/tail.js index d5be9713f..bad4e4d34 100644 --- a/src/log/tail.js +++ b/src/log/tail.js @@ -12,7 +12,8 @@ module.exports = (send) => { if (err) { return callback(err) } - const outputStream = pump(response, ndjson.parse()) + const outputStream = ndjson.parse() + pump(response, outputStream) callback(null, outputStream) }) }) diff --git a/src/utils/converter.js b/src/utils/converter.js index 444064bf3..b721173e1 100644 --- a/src/utils/converter.js +++ b/src/utils/converter.js @@ -44,9 +44,10 @@ class ConverterStream extends TransformStream { } function converter (inputStream, callback) { - const outputStream = pump( + const outputStream = new ConverterStream() + pump( inputStream, - new ConverterStream(), + outputStream, (err) => { if (err) { callback(err) diff --git a/src/utils/send-request.js b/src/utils/send-request.js index 3ab2b57e9..90f436d47 100644 --- a/src/utils/send-request.js +++ b/src/utils/send-request.js @@ -46,7 +46,8 @@ function onRes (buffer, cb) { // Return a stream of JSON objects if (chunkedObjects && isJson) { - const outputStream = pump(res, ndjson.parse()) + const outputStream = ndjson.parse() + pump(res, outputStream) res.on('end', () => { let err = res.trailers['x-stream-error'] if (err) {