Skip to content
This repository has been archived by the owner on Mar 10, 2020. It is now read-only.

Getting CI green #713

Closed
9 tasks done
vmx opened this issue Mar 12, 2018 · 8 comments
Closed
9 tasks done

Getting CI green #713

vmx opened this issue Mar 12, 2018 · 8 comments

Comments

@vmx vmx self-assigned this Mar 12, 2018
@daviddias
Copy link
Contributor

@vmx double check, but I think you also need #695

@vmx
Copy link
Contributor Author

vmx commented Mar 14, 2018

@diasdavid So far it doesn't seem that I need #695, except if it fixes ipfs-inactive/interface-js-ipfs-core#227 (i haven't tried yet)

@daviddias daviddias mentioned this issue Mar 14, 2018
@vmx
Copy link
Contributor Author

vmx commented Mar 14, 2018

With the outstanding PRs merged and these three reverted:

CI is quite often green. It's still not reliable, but as different tests are failing I'd consider them environment issues.

@vmx
Copy link
Contributor Author

vmx commented Mar 16, 2018

@diasdavid Everything from my side is merged now. The test runs are quite stable now. Now only the tests broken by the commits mentioned above need to be fixed. Who will fix those? The authors of those commits?

Edit: This is what it looks like without those commits reverted https://ci.ipfs.team/blue/organizations/jenkins/IPFS%2Fjs-ipfs-api/detail/get-ci-green/70/tests

@daviddias
Copy link
Contributor

@vmx would you have the chance to fix those too? thanks!

@vmx
Copy link
Contributor Author

vmx commented Mar 16, 2018

@diasdavid Not sure when, but I can have a look if it isn't fixed in the meantime.

@daviddias
Copy link
Contributor

@vmx I went through it. the files.stat was failing because it was expecting features that haven't been released on go-ipfs. ALl good now :)

@vmx
Copy link
Contributor Author

vmx commented Mar 16, 2018

Thanks David for fixing those! I'm looking forward to have js-ipfs-api green fingerscrossed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants