This repository has been archived by the owner on Mar 10, 2020. It is now read-only.
fixed json-loader error #784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @leekt216! Could you please remove the DS_Store files from your PR and also remove the |
|
Thanks @alanshaw i removed DS_Store and json-loader |
danieldaf
pushed a commit
to danieldaf/js-ipfs-api
that referenced
this pull request
Jul 21, 2018
…ive#784) * fixed json-loader error * add DS_Store * removed DS_Store * removed json-loader
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
while checking out upload-file-via-browser example,
i encountered "cannot resolve module json-loader" error
it was simply solved by updating webpack from 1.9.6-> 2.0.0
since json works on default since webpack 2.0.0 https://github.com/webpack-contrib/json-loader
react-hot & babel loader had to be specified( add '-loader')