This repository has been archived by the owner on Aug 12, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 20
Browser performance issue #187
Labels
P0
Critical: Tackled by core team ASAP
Comments
This was referenced Sep 11, 2017
@Beanow could you share an update of the results with the new pull-block? |
@diasdavid pull-block 1.2.1 makes a huge difference. pull-block 1.2.0
pull-block 1.2.1
A new install of IPFS does not bring it in yet though. |
daviddias
added
P0
Critical: Tackled by core team ASAP
status/ready
Ready to be worked
and removed
status/ready
Ready to be worked
labels
Oct 17, 2017
Wowow! That is incredible. Thanks so much @Beanow! |
Continuous on #190 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
In a very similar fashion to libp2p/js-libp2p-secio#92 I find that adding large files spends a huge amount of time garbage collecting buffers.
I.e. adding a 55MB file cost me about 20 seconds doing >10k GC runs on Firefox.
I'm in the process of narrowing down the culprit, but it seems to be the
pull-block
implementation used in the fixed size chunker.The text was updated successfully, but these errors were encountered: