Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add telemetry documentation #35
feat: add telemetry documentation #35
Changes from 6 commits
9e0ce60
41a2dbe
7695322
1f1acc7
ce7d99c
788b34f
70e88fc
d19132a
02d9f7f
1570b54
f2f2b65
a3fd171
1a97fe7
8aef1e4
5114692
1cd8e6d
b682ca7
c40f691
ca11b03
d698a85
669bc3c
7d0f222
9b93a1f
3930838
f9ff25a
02087b7
94ef59d
b119380
8181dbb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will need to point to
main/
prior to mergingThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(just an idea for the future)
We could replace these with aliases at
ipfs.fyi
(https://github.com/ipfs/ipfs.fyi):There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love the idea but I'm not sure exactly how this works and there doesn't seem to be enough info in the readme. Are we supposed to create a _redirects file in each repo, or just in this repo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggested hiding implementation details and making this more human-readable in ipfs/ipfs-companion#1117 (review). Default high level explainer should just note we gather feature usage telemetry to help maintainers prioritize work and if user wants to learn more, then fine to show more detail about event types we send and why.
We don't want to obfuscate things by using too much technical jargon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think each app will link to own or global Privacy Policy as the source of truth, monitoring it should be always enough. No reason to ask user to read RN or follow multiple repos :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should stay, but have a separate header: