Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option to customize Default Public Gateway #284

Closed
lidel opened this issue Sep 21, 2017 · 1 comment
Closed

Option to customize Default Public Gateway #284

lidel opened this issue Sep 21, 2017 · 1 comment
Labels
kind/enhancement A net-new feature or improvement to an existing feature

Comments

@lidel
Copy link
Member

lidel commented Sep 21, 2017 •
edited
Loading

Good suggestion by @lockedshadow from #16 (comment):

Maybe it's possible to add an option to select which public gateway to substitute in generated URL, if there are more than one in Preferences? For now it seems to be hardcoded on ipfs.io.

Yes, right now https://ipfs.io/ is hardcoded.

A good feature would be to specify custom one and use it in:

  • Copy public gateway URL function
  • links made by linkifyDOM experiment
  • custom protocol handlers when IPFS API is down (fallback to public gateway)
@lidel lidel added the kind/enhancement A net-new feature or improvement to an existing feature label Sep 21, 2017
@lidel lidel mentioned this issue Sep 21, 2017
Closed
4 tasks
lidel added a commit that referenced this issue Oct 6, 2017
@lidel
feat: Option to customize Default Public Gateway
b779da7 
Now that we can detect IPFS resources on any page,
list of public gateways is no longer needed.

This commit replaces the list with type-safe URL
of a single public gateway.

User-defined public gateway is used in:

- "copy public gateway URL" function
- links made by linkifyDOM experiment
- custom protocol handlers when IPFS API is down
  (fallback gateway)

Closes #284
@lidel lidel closed this as completed in 6bb4ba1 Oct 8, 2017
@lidel
Copy link
Member Author

lidel commented Oct 8, 2017

FYI this feature landed in v2.0.11 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement A net-new feature or improvement to an existing feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lidel