Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display release notes upon updating Companion version #912

Closed
jessicaschilling opened this issue Jul 16, 2020 · 2 comments · Fixed by #913
Closed

Display release notes upon updating Companion version #912

jessicaschilling opened this issue Jul 16, 2020 · 2 comments · Fixed by #913
Assignees
@jessicaschilling
Labels
effort/hours Estimated to take one or several hours exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature P1 High: Likely tackled by core team if no one steps up status/ready Ready to be worked topic/design-front-end Front-end implementation of UX/UI work

Comments

@jessicaschilling
Copy link
Contributor

As proposed in #662 (comment), send user to https://github.com/ipfs/ipfs-companion/releases/latest upon updating version of Companion.
@jessicaschilling jessicaschilling added exp/novice Someone with a little familiarity can pick up effort/hours Estimated to take one or several hours help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature P1 High: Likely tackled by core team if no one steps up status/ready Ready to be worked topic/design-front-end Front-end implementation of UX/UI work labels Jul 16, 2020
@jessicaschilling jessicaschilling mentioned this issue Jul 16, 2020
Open
@jessicaschilling jessicaschilling self-assigned this Jul 16, 2020
@lidel
Copy link
Member

lidel commented Jul 16, 2020

I think /latest will always link to the stable version, to make it work for Beta channel as well we should send user to version from manifest:

`https://github.com/ipfs-shipyard/ipfs-companion/releases/tag/v${browser.runtime.getManifest().version}`

@jessicaschilling jessicaschilling mentioned this issue Jul 16, 2020
Merged
@jessicaschilling
Copy link
Contributor Author

#913 will close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jessicaschilling jessicaschilling

Labels
effort/hours Estimated to take one or several hours exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature P1 High: Likely tackled by core team if no one steps up status/ready Ready to be worked topic/design-front-end Front-end implementation of UX/UI work
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Display channel-appropriate release notes upon Companion version update ipfs/ipfs-companion
2 participants
@lidel @jessicaschilling