Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning about mixed content issues #650

Merged
merged 4 commits into from
Jan 7, 2019
Merged

Conversation

lidel
Copy link
Member

@lidel lidel commented Jan 2, 2019

Closes #648

This PR checks if URL would trigger mixed content error and if check is positive displays an inline warning message:

2019-01-02--11-56-33

@olizilla does the copy look ok?

@lidel lidel requested a review from olizilla January 2, 2019 11:06
@ghost ghost assigned lidel Jan 2, 2019
@ghost ghost added the status/in-progress In progress label Jan 2, 2019
Copy link
Member

@olizilla olizilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is good as is, have suggested a minor tweak.

add-on/_locales/en/messages.json Outdated Show resolved Hide resolved
olizilla and others added 2 commits January 2, 2019 12:39
add-on/src/options/forms/gateways-form.js Outdated Show resolved Hide resolved
add-on/_locales/en/messages.json Outdated Show resolved Hide resolved
@da2x
Copy link

da2x commented Jan 3, 2019

Sorry, but I forgot about IPv6 in #648. It’s one more valid address that is whitelisted as secure by browsers. The inclusion of a third address does make the warning message messy, though. Not sure how to improve it without reformatting it as a list or maybe even linking to a wiki page with valid addresses and more information?

@lidel
Copy link
Member Author

lidel commented Jan 3, 2019

Good catch @da2x! I've added it and it's not that bad actually (a technical person will know what's up, a non-technical won't need to touch this field anyway).

2019-01-03--15-41-45

ps. ipv6 looks really nice in location bar!

2019-01-03--15-51-25

@lidel lidel added the UX label Jan 3, 2019
@lidel lidel merged commit d59416d into master Jan 7, 2019
@ghost ghost removed the status/in-progress In progress label Jan 7, 2019
@lidel lidel deleted the feat/mixed-content-warning branch January 7, 2019 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants