You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Of course we don't want to do that when fallback to browserified js-ipfs is used, but if external IPFS API is accessed over HTTP API or window.ipfs there should be an additional step of adding wrapping directory to MFS.
We should put the time of upload in the name of root directory to make it possible to display uploads in lexical order (this enables user to cleanup old uploads or easily find the latest one)
Maybe something like /shared/YYYY-MM-YY_HH-MM-SS?
It does not pollute the MFS root and is self-explanatory.
I don't see the point of using the MFS for this app, at least in its first stages 🤔
For now this app is oriented for just one flow:
You add files to IPFS
Share the link
Done
When you get back to the app is to start the flow all over again, instead of modifying the state of what you previously added (you can't even do that right now).
I think you are right. It is better to keep this as an explicit user action.
WebUI now has option to "Add from IPFS Path" so it should be enough for first iteration.
I am closing this, we may revisit this when integration between webui and share app begins.
As noted in Design: Pinning Content we are moving away from using low level pins and instead we keep data around by adding references to MFS.
First part is already done in this app, it does not pin uploaded content:
ipfs-share-files/src/bundles/files.js
Line 204 in 3d8c417
What is missing is adding content to MFS.
Of course we don't want to do that when fallback to browserified js-ipfs is used, but if external IPFS API is accessed over HTTP API or window.ipfs there should be an additional step of adding wrapping directory to MFS.
We should put the time of upload in the name of root directory to make it possible to display uploads in lexical order (this enables user to cleanup old uploads or easily find the latest one)
Maybe something like
/shared/YYYY-MM-YY_HH-MM-SS
?It does not pollute the MFS root and is self-explanatory.
cc @ipfs-shipyard/gui ipfs/ipfs-companion#415
The text was updated successfully, but these errors were encountered: