Git makes explorer unhappy

[whyrusleeping]

Loading this: https://ipfs.io/ipfs/QmYJETQ15RAnKXoJxqpXzcvQ2DuQA35UHwJBTjTPCSs9Ky/#/explore/QmViWi5az9iiPzESM6ruHf84TcmHSAVQ2KQdNveoDH7eaY/refs/heads/master

(or traversing the graph to it from above) results in it getting pretty angry and not working (and spinning cpus)

[olizilla]

Looks like an error is getting smothered

from js-cid
errorMsg = "multihash length inconsistent: 0x1114dc23ffefcd2feaef8036fda45e949afd86aae5d7"

[olizilla]

Failed to parse CID 8mWaJHXieAVxxLagBpdaNWFEBKVWmMiE Error: multihash length inconsistent: 0x1114dc23ffefcd2feaef8036fda45e949afd86aae5d7
    at Function.validateCID (index.js:235)

[olizilla]

Goes a wrong 'un here

https://github.com/multiformats/js-multihash/blob/2ace8ba9af7a4cd9c33c9480bfe382bb774e3f7d/src/index.js#L90-L100

[olizilla]

We get the same error from the cid util, http://cid-utils.ipfs.team/#8mWaJHXieAVxxLagBpdaNWFEBKVWmMiE which isn't suprising as they both use js-cid

[olizilla]

@whyrusleeping i got to sleeps now, if you have a moment to adjudicate over whether js-multihash is bugsy, or 8mWaJHXieAVxxLagBpdaNWFEBKVWmMiE is a wonky CID, then let me know and I'll get it fixed tomorrow.

[olizilla]

Ooh is it because I'm passing a raw git hash and asking it to be a cid, when it is not one.

[whyrusleeping]

@olizilla huh, it looks like go-ipfs doesnt like that hash either. cc @magik6k, whats up with that hash?

[whyrusleeping]

Oh right, it needs the 'z' prefix: z8mWaJHXieAVxxLagBpdaNWFEBKVWmMiE

[olizilla]

@whyrusleeping IPLD Explorer shouldn't panic'n'freak out in that case, but can you confirm that this is a rogue block with a wonky link, rather than a legit arrangement of things that it should be rendering.

[whyrusleeping]

@olizilla It does not appear to be a rogue block, if you look here: https://ipfs.io/api/v0/dag/get?arg=QmViWi5az9iiPzESM6ruHf84TcmHSAVQ2KQdNveoDH7eaY/refs/heads

You can see the 'z' multibase prefix is correctly applied

[olizilla]

ruh roh. I shall go digging.

[olizilla]

@whyrusleeping js-ipld-dag-pb assumes that the link value in a dag-pb link will be a multihash, not a cid: https://github.com/ipld/js-ipld-dag-pb/blob/70b0cd53148fa26dc3e75fe250c0f1ad8161a59e/src/dag-link/index.js#L8-L23

[olizilla]

I haven't tested it and I'm not super familiar with that code, but my guess is that's a problem

[olizilla]

More ipld/js-ipld-dag-pb#79

[olizilla]

ERH MER GLERB! IT GIT!