-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: helper-ui input-validator update #202
feat: helper-ui input-validator update #202
Conversation
the input validator now accepts the same urls as verified-fetch and provides more helpful information
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
self review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From a code perspective looks really clean and correct for all the formats accepted. all the tests.
A couple points regarding UX:
- The help text with all the accepted formats is overwhelming. My opinion is that we should be a little more prescriptive about the preferred/conventional format while gracefully accepting others (without advertising all of the the graceful cases). The formats with
example.com
are particularly confusing. - I'm somewhat surprised that we don't accept
ipfs://
andipns://
paths. I thought those would be considered the canonical form. I'm also that the/ipfs/..
and/ipns/..
are also common conventions in Kubo. - Perhaps instead of adding
/path
to each example, you omit it from all and update the note to say that you can suffix any path with a path?
Ok good to know, do you or @lidel have recommended example text we should include here?
😲 I missed that. wow. Will add.
good advice |
It still feels overwhelming. No need to flood user with all variants and permutations. Maybe simplify closer to:
|
Ok will do |
…ith-expected-format
Agree, one example per type looks better 👍 Lgtm, but while we are at it, we could improve two things:
|
merging due to implicit approvals via emojis on comments |
Title
feat: helper-ui input-validator update
Description
Fixes #66
Notes & open questions
the input validator now accepts the same urls as verified-fetch (more actually since https? is not required) and provides more helpful information
Change checklist