From f78c9ac808fd259be95c660ca12967a408fb0f5b Mon Sep 17 00:00:00 2001
From: Cayman <caymannava@gmail.com>
Date: Mon, 29 Jul 2024 02:59:48 -0600
Subject: [PATCH] feat: move tsc linter rules to eslint (#1513)

- Resolves https://github.com/ipfs/aegir/issues/1459
- Since all relevant typescript linter rules are now incorporated in the latest eslint-config-ipfs, we can drop them from our tsconfig.

---------

Co-authored-by: Russell Dempsey <1173416+SgtPooki@users.noreply.github.com>
---
 src/config/tsconfig.aegir.json                      | 5 -----
 test/fixtures/dependency-check/fail-unused/index.js | 1 -
 test/fixtures/dependency-check/ts-fail/src/index.ts | 1 -
 test/fixtures/dependency-check/ts-pass/src/index.ts | 1 -
 4 files changed, 8 deletions(-)

diff --git a/src/config/tsconfig.aegir.json b/src/config/tsconfig.aegir.json
index 0d4d47438..013a02cf6 100644
--- a/src/config/tsconfig.aegir.json
+++ b/src/config/tsconfig.aegir.json
@@ -21,11 +21,6 @@
         // module resolution
         "esModuleInterop": true,
         "moduleResolution": "node",
-        // linter checks
-        "noImplicitReturns": false,
-        "noFallthroughCasesInSwitch": true,
-        "noUnusedLocals": true,
-        "noUnusedParameters": false,
         // advanced
         "verbatimModuleSyntax": true,
         "forceConsistentCasingInFileNames": true,
diff --git a/test/fixtures/dependency-check/fail-unused/index.js b/test/fixtures/dependency-check/fail-unused/index.js
index 0499edc20..0779a5c78 100644
--- a/test/fixtures/dependency-check/fail-unused/index.js
+++ b/test/fixtures/dependency-check/fail-unused/index.js
@@ -1,3 +1,2 @@
 /* eslint-disable no-unused-vars */
-// @ts-expect-error unused
 import { execa } from 'execa'
diff --git a/test/fixtures/dependency-check/ts-fail/src/index.ts b/test/fixtures/dependency-check/ts-fail/src/index.ts
index b0c8f387a..0a6f23f99 100644
--- a/test/fixtures/dependency-check/ts-fail/src/index.ts
+++ b/test/fixtures/dependency-check/ts-fail/src/index.ts
@@ -1,4 +1,3 @@
 /* eslint-disable @typescript-eslint/no-unused-vars */
-// @ts-expect-error unused
 import { execa } from 'execa'
 import './other.js'
diff --git a/test/fixtures/dependency-check/ts-pass/src/index.ts b/test/fixtures/dependency-check/ts-pass/src/index.ts
index 0b6a46149..e8afcb68d 100644
--- a/test/fixtures/dependency-check/ts-pass/src/index.ts
+++ b/test/fixtures/dependency-check/ts-pass/src/index.ts
@@ -1,3 +1,2 @@
 /* eslint-disable @typescript-eslint/no-unused-vars */
-// @ts-expect-error unused
 import { execa } from 'execa'