-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gateway: migrate subdomain and dnslink code #149
Comments
@hacdias this is lower priority than PoC examples (#141 and #142), but something we will need for the production binary for Not sure how tricky this is, but these additional types of gateways are essentially wrappers executed before passing request to the path one. I think this is a good patter/model to follow in our library. |
(Oops, moving on...)
@lidel Any reason to do so instead of doing the common middleware pattern we see in Go? func Middleware(http.Handler) http.Handler
|
@hacdias don't remember, possible it is this way only for legacy reasons (subdomains were bolted-on years after path gateway was an ossified thing, did nto want to change too much because we had virtually no tests for anything gateway related back then). If you can switch Kubo to middleware pattern and have subdomain sharness pass, then we can clean this up 👍 |
Logic that parses
Host
header and translates it to content path is still in Kubo.We need to migrate it as well, because the gateway binary for Saturn MUST also support subdomain (for
dweb.link
) and DNSLink gateways (for things likehttps://en.wikipedia-on-ipfs.org
).Ref.
Other ToDos:
The text was updated successfully, but these errors were encountered: