Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

blockstore: remove HashOnRead #365

Open
lidel opened this issue Jun 19, 2023 · 0 comments
Open

blockstore: remove HashOnRead #365

lidel opened this issue Jun 19, 2023 · 0 comments
Labels
need/triage Needs initial labeling and prioritization

Comments

@lidel
Copy link
Member

lidel commented Jun 19, 2023 •
edited
Loading

Filling issue based on poc code in ipfs/go-ipfs-blockstore#51:

Instead, provide a simple ValidatingBlockstore wrapper. This:

  1. Isn't racy (fixes HashOnRead Has A Race Condition go-ipfs-blockstore#49).
  2. Keeps the base blockstore simple.

👉 Really, "HashOnRead" should never have been a part of the blockstore API in the
first place.
@lidel lidel added the need/triage Needs initial labeling and prioritization label Jun 19, 2023
@lidel lidel mentioned this issue Jun 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
need/triage Needs initial labeling and prioritization
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lidel