Impact
An attacker is able allocate arbitrarily many bytes in the Bitswap server by sending many WANT_BLOCK and or WANT_HAVE requests which are queued in an unbounded queue, with allocations that persist even if the connection is closed.
This affects users accepting untrusted connections with the Bitswap server, this also affects users using the old API stubs at github.com/ipfs/boxo/bitswap because it transitively uses github.com/ipfs/boxo/bitswap/server.
We have renamed go-libipfs to boxo; this document uses both terms interchangeably. The version numbers for both are applicable, as they share the same historical timeline.
Remediation
Apply one of:
- Update
boxo to v0.6.0 or later
- Update
boxo to v0.4.1
Note that v0.5.0 is NOT safe, v0.4.1 is a backport of the v0.6.0 security fixes on top of v0.4.0.
Mitigations
- The server now limits how many wantlist entries per peer it knows.
The MaxQueuedWantlistEntriesPerPeer option allows configuring how many wantlist entries the server remembers; if a peer sends a wantlist bigger than this (including a sum of multiple delta updates) the server will truncate the wantlist to the match the limit.
This defaults to 1024 entries per peer.
- The server now properly clears state about peers when they disconnect.
Peer state is more lazily allocated (only when a wantlist is received in the first place) and is properly cleared when the PeerDisconnected callback is received.
- The server now ignores CIDs above some size.
Clients were able to send any CID as long as the total protobuf message were bellow the 4MiB limit. This is allowed to allocate lots of memory with very little entries.
This can be configured using the MaxCidSize option and defaults to 168 bytes.
- The server now closes the connection if an inline CID is requested (either as
WANT_* or CANCEL).
The attack were more effective if done with CIDs that are present in target's blockstore, this is because this will push longer-lasting jobs on some priority queue.
Since inline CID are literal data (instead of hashes of data), everyone always "has" any inline CID (since instead of loading the data from disk, it can be extracted from the CID). It makes no sense for anyone to ever ask you about an inline CID since they could also just parse it themselves. Thus, as a defensive measure, we kill the connection with peers that ask about an inline CID.
Vulnerable symbols
github.com/ipfs/go-libipfs/bitswap/server/internal/decision.(*Engine).MessageReceivedgit.luolix.top/ipfs/go-libipfs/bitswap/server/internal/decision.(*Engine).NotifyNewBlocksgit.luolix.top/ipfs/go-libipfs/bitswap/server/internal/decision.(*Engine).findOrCreategit.luolix.top/ipfs/go-libipfs/bitswap/server/internal/decision.(*Engine).PeerConnected
Patches
Workarounds
If you are using the stubs at github.com/ipfs/go-libipfs/bitswap and not taking advantage of the features provided by the server, refactoring your code to use the new split API will allow you to run in a client-only mode using: github.com/ipfs/boxo/bitswap/client.
Impact
An attacker is able allocate arbitrarily many bytes in the Bitswap server by sending many
WANT_BLOCKand orWANT_HAVErequests which are queued in an unbounded queue, with allocations that persist even if the connection is closed.This affects users accepting untrusted connections with the Bitswap server, this also affects users using the old API stubs at
github.com/ipfs/boxo/bitswapbecause it transitively usesgit.luolix.top/ipfs/boxo/bitswap/server.We have renamed go-libipfs to boxo; this document uses both terms interchangeably. The version numbers for both are applicable, as they share the same historical timeline.
Remediation
Apply one of:
boxotov0.6.0or laterboxotov0.4.1Note that
v0.5.0is NOT safe,v0.4.1is a backport of thev0.6.0security fixes on top ofv0.4.0.Mitigations
The
MaxQueuedWantlistEntriesPerPeeroption allows configuring how many wantlist entries the server remembers; if a peer sends a wantlist bigger than this (including a sum of multiple delta updates) the server will truncate the wantlist to the match the limit.This defaults to
1024entries per peer.Peer state is more lazily allocated (only when a wantlist is received in the first place) and is properly cleared when the
PeerDisconnectedcallback is received.Clients were able to send any CID as long as the total protobuf message were bellow the 4MiB limit. This is allowed to allocate lots of memory with very little entries.
This can be configured using the
MaxCidSizeoption and defaults to168 bytes.WANT_*orCANCEL).The attack were more effective if done with CIDs that are present in target's blockstore, this is because this will push longer-lasting jobs on some priority queue.
Since inline CID are literal data (instead of hashes of data), everyone always "has" any inline CID (since instead of loading the data from disk, it can be extracted from the CID). It makes no sense for anyone to ever ask you about an inline CID since they could also just parse it themselves. Thus, as a defensive measure, we kill the connection with peers that ask about an inline CID.
Vulnerable symbols
github.com/ipfs/go-libipfs/bitswap/server/internal/decision.(*Engine).MessageReceivedgit.luolix.top/ipfs/go-libipfs/bitswap/server/internal/decision.(*Engine).NotifyNewBlocksgit.luolix.top/ipfs/go-libipfs/bitswap/server/internal/decision.(*Engine).findOrCreategit.luolix.top/ipfs/go-libipfs/bitswap/server/internal/decision.(*Engine).PeerConnectedPatches
Workarounds
If you are using the stubs at
github.com/ipfs/go-libipfs/bitswapand not taking advantage of the features provided by the server, refactoring your code to use the new split API will allow you to run in a client-only mode using:github.com/ipfs/boxo/bitswap/client.