This repository has been archived by the owner on Feb 1, 2023. It is now read-only.

Limit the number of retries when sending messages #48

Closed

Stebalien opened this issue Dec 29, 2018 · 1 comment · Fixed by #72

Assignees

Member

Stebalien commented Dec 29, 2018

We should give up if we keep failing instead of retrying until we fail to connect.

go-bitswap/messagequeue/messagequeue.go

Lines 164 to 170 in 916de59

    
           	// send wantlist updates 
        
           	for { // try to send this message until we fail. 
        
           		if mq.attemptSendAndRecovery(ctx, wlm) { 
        
           			return 
        
           		} 
        
           	} 
        
           }

Stebalien assigned hannahhoward

Contributor

hannahhoward commented Jan 10, 2019

When multiple attemps fail, we should also remove the failed peer from the peer manager.

hannahhoward mentioned this issue

fix(wantlist): remove races on setup #72

Merged

Stebalien closed this as completed in #72

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.