Skip to content
This repository has been archived by the owner on Mar 28, 2023. It is now read-only.

Method proto.DelegatedRouting_Client.GetIPNS is never used. #30

Closed
Tracked by #9150
ajnavarro opened this issue Jul 6, 2022 · 3 comments
Closed
Tracked by #9150

Method proto.DelegatedRouting_Client.GetIPNS is never used. #30

ajnavarro opened this issue Jul 6, 2022 · 3 comments
Labels
kind/bug A bug in existing code (including security flaws) need/triage Needs initial labeling and prioritization

Comments

@ajnavarro
Copy link
Member

ajnavarro commented Jul 6, 2022 •
edited
Loading

Client implementation uses GetIPNSAsync for GetIPNS.
@ajnavarro ajnavarro added kind/bug A bug in existing code (including security flaws) need/triage Needs initial labeling and prioritization labels Jul 6, 2022
@ajnavarro ajnavarro changed the title Methods proto.DelegatedRouting_Client.GetIPNS and proto.DelegatedRouting_Client.PutIPNS are never used. Method proto.DelegatedRouting_Client.GetIPNS is never used. Jul 6, 2022
@ajnavarro ajnavarro mentioned this issue Jul 25, 2022
Closed
9 tasks
@BigLep
Copy link

BigLep commented Jul 25, 2022

@ajnavarro : I'm confused. What is the done criteria for this issue? I assume we're removing something? Lets please specify that.

@BigLep BigLep mentioned this issue Jul 25, 2022
Closed
9 tasks
@ajnavarro
Copy link
Member Author

ajnavarro commented Jul 26, 2022 •
edited
Loading

Actually, I'm not sure. I would say to use DelegatedRouting_Client.GetIPNS instead of DelegatedRouting_Client.GetIPNS_Async will be the right approach, but maybe I'm missing something and it is done that way for a reason.

Here is the confusing line https://github.com/ipfs/go-delegated-routing/blob/main/client/getipns.go#L13

@ajnavarro ajnavarro mentioned this issue Jul 29, 2022
Closed
@ajnavarro
Copy link
Member Author

Fix not needed.

@ajnavarro ajnavarro closed this as not planned Won't fix, can't repro, duplicate, stale Sep 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
kind/bug A bug in existing code (including security flaws) need/triage Needs initial labeling and prioritization
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Call directly to client.GetIPNS impl. ajnavarro/go-delegated-routing
2 participants
@BigLep @ajnavarro