Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please close the psubTopic #227

Closed
wenyue opened this issue Mar 29, 2024 · 5 comments · Fixed by #247
Closed

Please close the psubTopic #227

wenyue opened this issue Mar 29, 2024 · 5 comments · Fixed by #247
Labels
need/triage Needs initial labeling and prioritization

Comments

@wenyue
Copy link

wenyue commented Mar 29, 2024

Please close the psubTopic when the context is done.

@wenyue wenyue added the need/triage Needs initial labeling and prioritization label Mar 29, 2024
Copy link

welcome bot commented Mar 29, 2024

Thank you for submitting your first issue to this repository! A maintainer will be here shortly to triage and review.
In the meantime, please double-check that you have provided all the necessary information to make this process easy! Any information that can help save additional round trips is useful! We currently aim to give initial feedback within two business days. If this does not happen, feel free to leave a comment.
Please keep an eye on how this issue will be labeled, as labels give an overview of priorities, assignments and additional actions requested by the maintainers:

  • "Priority" labels will show how urgent this is for the team.
  • "Status" labels will show if this is ready to be worked on, blocked, or in progress.
  • "Need" labels will indicate if additional input or analysis is required.

Finally, remember to use https://discuss.ipfs.io if you just need general support.

@hsanjuan
Copy link
Collaborator

Can you be more specific/provide more details?

@wenyue
Copy link
Author

wenyue commented Apr 14, 2024

In the NewPubSubBroadcaster function,we join and create a psubTopic object, and this object should be closed when the context is done.

@wenyue
Copy link
Author

wenyue commented Apr 18, 2024

Any update?

@hsanjuan
Copy link
Collaborator

Mind sending a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need/triage Needs initial labeling and prioritization
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants