Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close pubsub topic when broadcaster closes #247

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Close pubsub topic when broadcaster closes #247

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions pubsub_broadcaster.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,13 @@ func NewPubSubBroadcaster(ctx context.Context, psub *pubsub.PubSub, topic string
go func(ctx context.Context, subs *pubsub.Subscription) {
<-ctx.Done()
subs.Cancel()
// subs.Next returns error when subscription closed. Subscription must
// be closed before psubTopic can be closed.
var err error
for err == nil {
_, err = subs.Next(ctx)
}
psubTopic.Close()
}(ctx, subs)

return &PubSubBroadcaster{
Expand Down