Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graphsync does not return an error when the request context is cancelled #142

Closed
dirkmc opened this issue Jan 20, 2021 · 1 comment
Closed
Labels
need/triage Needs initial labeling and prioritization

Comments

@dirkmc
Copy link
Collaborator

dirkmc commented Jan 20, 2021

We found a problem in go-data-transfer whereby when the node shuts down

  • the context for all the outstanding requests are cancelled
  • go-data-transfer's graphsync transport consumes all outstanding requests
  • the graphsync request completes without returning an error
  • the transfer is marked as complete, even though it is incomplete

We worked around this problem by checking the if the request context was closed when the request finishes: filecoin-project/go-data-transfer#134. The correct solution would be to fix the underlying problem, which appears to be that graphsync does not return an error when the request context is cancelled.

@dirkmc dirkmc added the need/triage Needs initial labeling and prioritization label Jan 20, 2021
@hannahhoward
Copy link
Collaborator

This is no longer true I think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need/triage Needs initial labeling and prioritization
Projects
None yet
Development

No branches or pull requests

2 participants