Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework relay options #7228

Closed
Stebalien opened this issue Apr 27, 2020 · 7 comments
Closed

Rework relay options #7228

Stebalien opened this issue Apr 27, 2020 · 7 comments
Labels
exp/intermediate Prior experience is likely helpful kind/enhancement A net-new feature or improvement to an existing feature P2 Medium: Good to have, but can wait until someone steps up status/ready Ready to be worked

Comments

@Stebalien
Copy link
Member

The current relay options are confusing and dangerous. Setting EnableAutoRelay and EnableRelayHop will cause nodes to advertise themselves as relays to the rest of the network.

At a minimum, we should make EnableAutoRelay do what it looks like it should do: automatically use public relays. Then, we can:

  1. Remove EnableRelayHop. I'm concerned users have enabled this without having any idea what it does.
  2. Add a PublicRelayMode option with three variants: "disabled", "enabled", "i am an isp" (what EnableRelayHop + PublicRelayMode currently do).
@Stebalien Stebalien added kind/enhancement A net-new feature or improvement to an existing feature exp/intermediate Prior experience is likely helpful labels Apr 27, 2020
@hsanjuan
Copy link
Contributor

Priority, status, plus potential assignment to milestone please?

@Stebalien Stebalien added P2 Medium: Good to have, but can wait until someone steps up status/ready Ready to be worked labels Apr 29, 2020
@RubenKelevra
Copy link
Contributor

How about using default Linux terminology here?

  • "TrafficForwarding": (Enable/Disable)
    • Enabled or disabled that this node will forward any traffic
  • "AdvertiseTrafficForwarding: (Enable/Disable)
    • Enables or disables that this node will advertise itself as traffic forwarder (relay hop) to the network
  • "UseTrafficForwarding": (On/Auto/Off)
    • Enables or disables that this node will search and use traffic forwarder (relay hops). Auto will decide this based on the autonat status

@Stebalien
Copy link
Member Author

Calling it "relay" in some places and "traffic forwarding" in others is going to be really confusing.

@eminence
Copy link
Contributor

eminence commented Jun 4, 2021

Are there any options to control how a node advertises itself as providing relay services? For example, can I configure node A on my network to provide relay services only to other nodes on my LAN (and also configure the other nodes on my LAN to use node A as a relay)?

@Stebalien
Copy link
Member Author

Stebalien commented Jun 4, 2021 via email

@Winterhuman
Copy link
Contributor

@Stebalien Should this be closed now that EnableRelayHop is no longer an option (along with the other CircuitV1 options)?

@Stebalien
Copy link
Member Author

Yep!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
exp/intermediate Prior experience is likely helpful kind/enhancement A net-new feature or improvement to an existing feature P2 Medium: Good to have, but can wait until someone steps up status/ready Ready to be worked
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@Stebalien @eminence @RubenKelevra @hsanjuan @Winterhuman