Standardized Readme #2883
Merged
Standardized Readme #2883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RichardLitt
force-pushed
the
feature/standardize-readme
branch
from
487bc0c
to
9a073ad
Compare
See ipfs/community#124 License: MIT Signed-off-by: Richard Littauer <richard.littauer@gmail.com>
RichardLitt
force-pushed
the
feature/standardize-readme
branch
from
9a073ad
to
eb955df
Compare
|
LGTM |
| @@ -1,6 +1,6 @@ | |||
| The MIT License (MIT) | |||
|
|
|||
| Copyright (c) 2014 Juan Batiz-Benet | |||
| Copyright (c) 2016 Juan Batiz-Benet | |||
There was a problem hiding this comment.
No, you don't just "update" a copyright notice. the whole point is the earliest time. Also, in general don't remove things from copyright notices. should usually only add.
So if you want to say 2016, then you'd have to say:
Copyright (c) 2014 Juan Batiz-Benet
Copyright (c) 2016 Juan Batiz-Benet
or
Copyright (c) 2014-2016 Juan Batiz-Benet
or
Copyright (c) since 2014 Juan Batiz-Benet
RichardLitt
added a commit
that referenced
this pull request
Aug 29, 2016
See #2883 (comment) License: MIT Signed-off-by: Richard Littauer <richard.littauer@gmail.com>
Merged
RichardLitt
added a commit
that referenced
this pull request
Aug 29, 2016
See #2883 (comment). Will need to change current issues. License: MIT Signed-off-by: Richard Littauer <richard.littauer@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See ipfs/community#124