Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add repo verify command #2924

Merged
merged 2 commits into from
Jul 6, 2016
Merged

add repo verify command #2924

merged 2 commits into from
Jul 6, 2016

Conversation

whyrusleeping
Copy link
Member

License: MIT
Signed-off-by: Jeromy why@ipfs.io

@cryptix cryptix added the status/in-progress In progress label Jul 1, 2016
@whyrusleeping whyrusleeping added need/review Needs a review and removed status/in-progress In progress labels Jul 1, 2016
@kevina
Copy link
Contributor

kevina commented Jul 1, 2016

I would suggest that a non-zero exit code is returned from the command is some blocks failed.

Other than that it LGTM, but there are no test cases and I have not tested it manually.

License: MIT
Signed-off-by: Jeromy <why@ipfs.io>
License: MIT
Signed-off-by: Jeromy <why@ipfs.io>
@whyrusleeping whyrusleeping merged commit 2df8dc5 into master Jul 6, 2016
@whyrusleeping whyrusleeping deleted the feat/repo-verify branch July 6, 2016 18:39
return
}

out := make(chan interface{})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

buffer of 1?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i guess dont need it, but usually good to do it for cases like this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants