Build: Fix Makefile on Windows #2975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Péter Szilágyi <peterke@gmail.com>
License: MIT Signed-off-by: Dominic Della Valle <ddvpublic@gmail.com>
|
@djdv thanks so much for taking this on! :) I'll give it a try with docker tomorrow! |
|
|
|
@djdv Works for me now, thanks! |
|
Works for me too 👍 PS: Sorry for not reacting till now, we're having a bit of a crisis at Ethereum for the last month or so. |
|
LGTM, thanks everyone! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This request brings back in a reverted commit with a fix on top for platform delimiters.
Before this gets merged though I would like people to test it on various systems, it works for me in msys2 where it did not originally, but I only use a single GOPATH. If anyone could try building with this and report on the results I'd appreciate it.
@ChristianKniep
Could you run this and see if you have any build issues? (In relation to #2969)
@jefft0
Could you run this inside of Cygwin? I'm not sure if Cygwin will get picked up as Windows or not with this condition.